Make HttpQueryError hashable#8
Merged
syrusakbary merged 2 commits intographql-python:masterfrom Jul 19, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in the documentation for
__hash__()method in Python 3, if class overrides__eq__()but doesn't define__hash__(), this will implicitely be set toNone. This is the case ofHttpQueryErrorexception class. This causes issues for logging, particularlytracebackmodule which raisesTypeError: unhashable type: 'HttpQueryError'.Consider this minimal example:
This results in:
This PR adds
__hash__()method forHttpQueryErrorclass implemented as a call tohash()built-in function supplying tuple of components used in__eq__()(as suggested in the documentation).Note: This issue should be solved in Python 3.6 and Python 3.7 (see Issue 28603) which fixes formatting of tracebacks for unhashable exceptions.